Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template review: code templates should match the default scaffolding #29

Merged
merged 15 commits into from
Nov 13, 2014

Conversation

serra
Copy link
Contributor

@serra serra commented Dec 5, 2012

I'll use this pull request to port back some changes I made to the templates.

Notes

Depends on pull #65 (confirm delete)

Tasks

  • review ControllerWithContext.cs.tt bug, see ControllerWithContext.tt template bug #57 only namespace addition needed 5075381
  • all view templates should match the ones in _views\shared
    • Create
    • Details
    • Index (list.tt
    • What to do with Edit -> I chose to simply copy the Create.tt
    • Delete
  • Annoying: Having to manually remove the "custom tool" from the .tt files (otherwise we get a compile error)
  • Annoying: Having to close and open solution to remove build errors in temporary files

@erichexter
Copy link
Owner

so.. what would make it easier... creating a sample project that can run
with the files before they are transformed into the .pp extensions.. so we
can develop this inline and extract the package?
Eric Hexter

blog | http://Hex.LosTechies.com
info | http://www.linkedin.com/in/erichexter

On Wed, Dec 5, 2012 at 4:55 AM, Marijn van der Zee <[email protected]

wrote:

ime consu

@serra
Copy link
Contributor Author

serra commented Dec 6, 2012

Sounds good. Such a project could also serve to "communicate" the goals and concerns of the project too (see #27). E.g.:

  • developers can use any type of (view)model and twitter.bootstrap.mvc just works, no restrictions
  • twitter.bootstrap.mvc does not require any additional dependencies outside of the ui layer
  • ...

@erichexter
Copy link
Owner

I created a separate nuget for the templates..

as far as making it easier to back port changes.. this is the process you can use

modify the templates your using..
copy them into the bootstrap folder
from a separate vs instance run the build.ps1 from the nuget console.. then do a install-package for the .templates package.

you can also automate this process like i did in the test\endtoend\tests.ps1 file.. I run that from a nuget console in a separate instance of vs and I can easily try out the packages that the build.ps1 creates in a new solution.

@serra
Copy link
Contributor Author

serra commented Dec 23, 2012

That would work. I'll give have a look at it somewhere in the next couple of weeks.
My first goal would be to make sure the templates exactly match their corresponding defaults in ~/Views/Shared.

Nice work!

@erichexter
Copy link
Owner

should i merge this or are you just reviewing it?

@serra
Copy link
Contributor Author

serra commented Feb 1, 2013

I'd like to get all tasks checked before you merge. I'll reopen when done. Code templates are useful, but only if they match the default scaffolding.

And don't produce annoying compile errors, that's a big turn-off for me ATM.

@serra serra closed this Feb 1, 2013
@serra
Copy link
Contributor Author

serra commented Mar 28, 2013

@erichexter @MisterJames please consider accepting this pull, or add some feedback for me, so I can approve it. It's kind of blocking further improvements; e.g.#79 #89.

erichexter added a commit that referenced this pull request Nov 13, 2014
Template review: code templates should match the default scaffolding
@erichexter erichexter merged commit aa15efc into erichexter:master Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants