feat(process_reports): allow spec. of zero reports, default --preset to reset-contradictory
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to perform tainting without having to have reports on hand.
This allows terser invocations for invocations without reports specified, which we've just barely started allowing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, making these optional didn't make sense, as we didn't have any post-processing of metadata to do. Now that we do have post-processing, it seems wise to make these optional, so users can call
process-reportsand get the post-processing without actually having to."But Erich!" you might say. "Don't we already expose the current post-processing via
fmt?" And you'd be right! However, Mozilla is also considering a command that updating thebacklogstatus and be included infmt, which would technically be separate from the intended purpose ofprocess-reports, which is to update theexpectedfield.☝🏻Speaking of which, we should probably rename these commands to reflect their intent…🤔