added templateWrap callback option and strictMode boolean option #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 9, 2015 11:50
|
This would be great please merge this! |
|
Any plan to accept/review this PR? Must have feature :) |
|
@taylorcode Sorry for the delay. I'm down for merging this, but would need the forked changes in your |
|
Can anyone here help with #137? |
| @@ -47,7 +48,7 @@ var Compiler = function(grunt, options, cwd) { | |||
| // Append formatted URL | |||
| path += Url.format( Url.parse( url.replace(/\\/g, '/') ) ); | |||
|
|
|||
| return "\n $templateCache.put('" + path + "',\n " + template + "\n );\n"; | |||
| return options.templateWrap(path, template, index, files); | |||
There was a problem hiding this comment.
Can you give a reason why the template wrapper function might need the index or the full list of files? It doesn't look like they're used in your examples.
|
@taylorcode taking a look at this, and I really like the feature. Just had one question, and would request one or more tests for it. Also would you mind backing out the fork-specific changes to the README and package.json? Thanks! |
|
This also needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that it is useful if the developer can decide how the templates are registered. This allows them to use a different caching service, or even generate a json file (for example) with the templates instead of a js file.