New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repro bad NaN in #22 #23

Open

TSMMark wants to merge 1 commit into eric-malachias:master from Vydia:repro-bad-nan

TSMMark commented Apr 12, 2024

Thanks for this package btw

In #22 I mentioned that I was getting NaN. This PR reproduces the issue.

In this PR I added:

1 test that passes
1 test that fails with the exact same data, but $1 different negative initial investment – gets NaN

I'm hoping this is just the result of a simple bug in the library and @eric-malachias you will be able to identify and fix it.


          repro bad nan

b907b7c

and add passing test for almost identical data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet