Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear mempool transactions with inputs being spent immediately when a block arrives #2156

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

kushti
Copy link
Member

@kushti kushti commented May 2, 2024

Close #2155

@kushti kushti changed the base branch from master to v5.0.22 May 2, 2024 12:51
Copy link
Member

@aslesarenko aslesarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please see comment.

# re-check it every interval value
mempoolCleanupDuration = 20m
# re-check it every interval value (but only on new block arrival)
mempoolCleanupDuration = 30s
Copy link
Member

@aslesarenko aslesarenko May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify if block arrived, but the interval has not elapsed, does the re-check happen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@kushti kushti merged commit 87f3fb3 into v5.0.22 Jun 1, 2024
8 checks passed
@kushti kushti deleted the i2155 branch June 1, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear mempool transactions with inputs being spent
3 participants