Utxo set scanner #2072
Open
Utxo set scanner #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/scala/org/ergoplatform/nodeView/wallet/ErgoWalletActor.scala
kushti
requested changes
Dec 8, 2023
There was a problem hiding this comment.
- Please add ScalaDoc to all the non-private functions (such as iterateAVLTree, it is complex by both signature and implementation) and classes (including signals like StartUtxoSetScanWithHistory and StartUtxoSetScan)
- What is difference between StartUtxoSetScanWithHistory and StartUtxoSetScan ?
- How is it tested?
- Please do tests for iterateAVLTree at least, like done for
dumpSnapshot(seeproperty("dumping snapshot"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Utxo set scanner, which scans unspent boxes for the wallet when bootstrapping with Utxo set snapshot.
Closes #2034