Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init controller-runtime logger #6453

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

init controller-runtime logger
reference Github issue

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English init controller-runtime logger
🇨🇳 中文 修复controller-runtime报错

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from iutx October 16, 2024 07:59
iutx
iutx previously approved these changes Oct 16, 2024
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.62%. Comparing base (b46e4bf) to head (008c579).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sclient/client.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6453      +/-   ##
==========================================
+ Coverage   15.61%   15.62%   +0.01%     
==========================================
  Files        3674     3674              
  Lines      311277   311625     +348     
==========================================
+ Hits        48604    48699      +95     
- Misses     257248   257471     +223     
- Partials     5425     5455      +30     
Flag Coverage Δ
by-github-actions 15.62% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/k8sclient/client.go 20.00% <80.00%> (+12.85%) ⬆️

... and 9 files with indirect coverage changes

go.mod Outdated Show resolved Hide resolved
@sfwn
Copy link
Member

sfwn commented Oct 17, 2024

/approve

@erda-bot erda-bot merged commit cd296d5 into erda-project:master Oct 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants