Add code size and gas report to github CI #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekdefi
changed the title
prateekdefi
changed the title
arjun-io
reviewed
Oct 18, 2024
| @@ -0,0 +1,70 @@ | |||
| name: Gas Report and Code Size | |||
There was a problem hiding this comment.
One thing that's nice about these tools is that if there is a previous report it'll show the diff as well. Is there any way we could get that working? We might need to commit the reports to the repo
There was a problem hiding this comment.
Oh I see that the code size one does already have the diff
There was a problem hiding this comment.
Yeah gas diff would be incredible
There was a problem hiding this comment.
The tool shows the difference from the last run only. I looked but couldn't find a way to get diff from a previous report. @arjun-io
There was a problem hiding this comment.
Will need to play around in the gas report script to get a diff. Will try that tomorrow.
There was a problem hiding this comment.
Seems the goal here is to pull the "previous" report from the merge target branch. That implies reports for each branch need to be stored somewhere. Would also be nice to have this for coverage, though out-of-scope for this PR.
As a reviewer, this information should reveal how much larger the PR is making the code, and how much additional gas will be consumed by transactions impacted by the change.
There was a problem hiding this comment.
Right, the goal is to compare the code size changes and gas changes from base branch. Using a script I tried to compare code size and gas report tables among two branches and show the diff in a single table but that is causing a lot of issues so I think I should not spend more time on this.
I am thinking of running gas report on both the branches in the CI itself and printing two tables one below the other in a single github comment.
…d PR branch" This reverts commit 39961c1.
Code Size: |
Gas Report: |
[Periphery] Unit Test Coverage ReportCoverage after merging prateek/pe-1866-code-size-gas-report into v2.3 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Core] Integration Test Coverage ReportCoverage after merging prateek/pe-1866-code-size-gas-report into v2.3 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Periphery] Integration Test Coverage ReportCoverage after merging prateek/pe-1866-code-size-gas-report into v2.3 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Periphery] Combined Test Coverage ReportCoverage after merging prateek/pe-1866-code-size-gas-report into v2.3 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Core] Unit Test Coverage ReportCoverage after merging prateek/pe-1866-code-size-gas-report into v2.3 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
[Core] Combined Test Coverage ReportCoverage after merging prateek/pe-1866-code-size-gas-report into v2.3 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.