Skip to content

Commit

Permalink
remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
kbrizzle committed Jul 21, 2023
1 parent 115f1a9 commit fc47d49
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/perennial/contracts/Market.sol
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ contract Market is IMarket, Instance {

// oracle
(context.latestVersion, context.currentTimestamp) = _oracleVersion();
context.positionVersion = _oracleVersionAtPosition(context, _position.read()); // TODO: remove this
context.positionVersion = _oracleVersionAtPosition(context, _position.read());

// after
_endGas(context);
Expand Down Expand Up @@ -408,15 +408,15 @@ contract Market is IMarket, Instance {
/// @param newPosition The pending position to process
function _processPositionGlobal(Context memory context, Position memory newPosition) private {
Version memory version = _versions[context.latestPosition.global.timestamp].read();
OracleVersion memory oracleVersion = _oracleVersionAtPosition(context, newPosition); // TODO: seems weird some logic is in here
OracleVersion memory oracleVersion = _oracleVersionAtPosition(context, newPosition);
if (!oracleVersion.valid) newPosition.invalidate(context.latestPosition.global);

(uint256 fromTimestamp, uint256 fromId) = (context.latestPosition.global.timestamp, context.latestPosition.global.id);
(VersionAccumulationResult memory accumulationResult, UFixed6 accumulatedFee) = version.accumulate(
context.global,
context.latestPosition.global,
newPosition,
context.positionVersion, // TODO: ??
context.positionVersion,
oracleVersion,
context.marketParameter,
context.riskParameter
Expand Down

0 comments on commit fc47d49

Please sign in to comment.