Skip to content

v2.3 Audit Fixes

v2.3 Audit Fixes #1876

Triggered via pull request October 3, 2024 18:56
Status Cancelled
Total duration 5m 9s
Artifacts 6

CI.yml

on: pull_request
[Core] Unit Tests w/ Coverage
4m 31s
[Core] Unit Tests w/ Coverage
[Core] Integration Tests w/ Coverage
4m 31s
[Core] Integration Tests w/ Coverage
[Collateral Accounts] Integration Tests w/ Coverage
4m 24s
[Collateral Accounts] Integration Tests w/ Coverage
[Oracle] Integration Tests w/ Coverage
4m 29s
[Oracle] Integration Tests w/ Coverage
[Oracle] Sepolia Integration Tests w/ Coverage
4m 2s
[Oracle] Sepolia Integration Tests w/ Coverage
[Trigger Orders] Integration Tests w/ Coverage
4m 30s
[Trigger Orders] Integration Tests w/ Coverage
[Vault] Integration Tests w/ Coverage
4m 34s
[Vault] Integration Tests w/ Coverage
[Extensions] Integration Tests w/ Coverage
4m 30s
[Extensions] Integration Tests w/ Coverage
[Collateral Accounts] Unit Tests w/ Coverage
2m 48s
[Collateral Accounts] Unit Tests w/ Coverage
[Oracle] Unit Tests w/ Coverage
3m 8s
[Oracle] Unit Tests w/ Coverage
[Trigger Orders] Unit Tests w/ Coverage
2m 23s
[Trigger Orders] Unit Tests w/ Coverage
[Vault] Unit Tests w/ Coverage
2m 22s
[Vault] Unit Tests w/ Coverage
[Extensions] Unit Tests w/ Coverage
4m 30s
[Extensions] Unit Tests w/ Coverage
[Verifier] Unit Tests w/ Coverage
2m 6s
[Verifier] Unit Tests w/ Coverage
[Core] Combined Tests w/ Coverage
0s
[Core] Combined Tests w/ Coverage
Periphery Integration Tests Coverage
0s
Periphery Integration Tests Coverage
Periphery Unit Tests Coverage
0s
Periphery Unit Tests Coverage
Periphery Combined Tests Coverage
0s
Periphery Combined Tests Coverage
Fit to window
Zoom out
Zoom in

Annotations

16 errors and 18 warnings
[Collateral Accounts] Integration Tests w/ Coverage
Canceling since a higher priority waiting request for 'build-441' exists
[Collateral Accounts] Integration Tests w/ Coverage
The operation was canceled.
[Oracle] Integration Tests w/ Coverage
Canceling since a higher priority waiting request for 'build-441' exists
[Oracle] Integration Tests w/ Coverage
The operation was canceled.
[Trigger Orders] Integration Tests w/ Coverage
Canceling since a higher priority waiting request for 'build-441' exists
[Trigger Orders] Integration Tests w/ Coverage
The operation was canceled.
[Extensions] Unit Tests w/ Coverage
Canceling since a higher priority waiting request for 'build-441' exists
[Extensions] Unit Tests w/ Coverage
The operation was canceled.
[Extensions] Integration Tests w/ Coverage
Canceling since a higher priority waiting request for 'build-441' exists
[Extensions] Integration Tests w/ Coverage
The operation was canceled.
[Core] Integration Tests w/ Coverage
Canceling since a higher priority waiting request for 'build-441' exists
[Core] Integration Tests w/ Coverage
The operation was canceled.
[Core] Unit Tests w/ Coverage
Canceling since a higher priority waiting request for 'build-441' exists
[Core] Unit Tests w/ Coverage
The operation was canceled.
[Vault] Integration Tests w/ Coverage
Canceling since a higher priority waiting request for 'build-441' exists
[Vault] Integration Tests w/ Coverage
The operation was canceled.
Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Lint: packages/perennial-account/test/helpers/arbitrumHelpers.ts#L28
'IKept' is defined but never used
Lint
Code contains empty blocks
Lint
Contract name must be in CamelCase
Lint
Code contains empty blocks
Lint
Contract name must be in CamelCase
Lint
Explicitly mark visibility of state
Lint
Explicitly mark visibility of state
Lint
Explicitly mark visibility of state
Lint
Avoid to use inline assembly. It is acceptable only in rare cases
Lint: packages/perennial-deploy/deploy/004_deploy_market.ts#L1
'utils' is defined but never used
[Verifier] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Vault] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Trigger Orders] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Collateral Accounts] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Oracle] Unit Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[Oracle] Sepolia Integration Tests w/ Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "account_unit_test_coverage", "oracle_sepolia_integration_test_coverage", "oracle_unit_test_coverage", "order_unit_test_coverage", "vault_unit_test_coverage", "verifier_unit_test_coverage". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
account_unit_test_coverage
10.4 KB
oracle_sepolia_integration_test_coverage
12.3 KB
oracle_unit_test_coverage
12.3 KB
order_unit_test_coverage
5.41 KB
vault_unit_test_coverage
8.35 KB
verifier_unit_test_coverage
1.81 KB