Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use expect_eq rather than expect_that where applicable #110

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

eopb
Copy link
Owner

@eopb eopb commented Sep 3, 2024

This requires extra imports because googletest macros look for items in the local scope.

I've opened a PR to fix this google/googletest-rust#475

Once that is released, the extra imports will become unused.

@AjithPanneerselvam AjithPanneerselvam marked this pull request as ready for review September 4, 2024 16:10
@AjithPanneerselvam AjithPanneerselvam marked this pull request as draft September 4, 2024 16:11
Base automatically changed from push-qtrrqnkwuozw to main September 4, 2024 17:29
@eopb eopb force-pushed the push-wtmqxnswzpxu branch 2 times, most recently from ad52d4e to cae901c Compare September 4, 2024 19:01
This requires extra imports because googletest macros look for items in the local scope.

I've opened a PR to fix this google/googletest-rust#475

Once that is released, the extra imports will become unused.
@eopb eopb changed the title Attempt at using expect_eq Use expect_eq rather than expect_that where applicable Sep 4, 2024
@eopb eopb marked this pull request as ready for review September 4, 2024 19:07
@eopb eopb merged commit 04e98d1 into main Sep 4, 2024
7 checks passed
@eopb eopb deleted the push-wtmqxnswzpxu branch September 4, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants