Feat/entity permisions graphql #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gurable with spring properties.
|
testower
reviewed
Oct 22, 2024
| @@ -35,6 +35,18 @@ public interface AuthorizationService { | |||
| */ | |||
| void verifyCanDeleteEntities(Collection<? extends EntityStructure> entities); | |||
|
|
|||
| /** | |||
| * Verify that the current user has right to delete the given entity. | |||
| * @throws AccessDeniedException if not. | |||
There was a problem hiding this comment.
boolean and throwing AccessDeniedException. Will this method ever return false?
testower
reviewed
Oct 22, 2024
| @@ -67,5 +77,46 @@ public <T extends EntityStructure> Set<String> getRelevantRolesForEntity(T entit | |||
| return dataScopedAuthorizationService.getRelevantRolesForEntity(entity); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean canDeleteEntity(EntityStructure entity) { | |||
There was a problem hiding this comment.
Does this account for zone restrictions?
testower
reviewed
Oct 22, 2024
|
|
||
| @Override | ||
| public boolean canEditEntity(EntityStructure entity) { |
There was a problem hiding this comment.
Does this account for zone restriction?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended graphql api to show entity permission.