Add bounding box search functionality to vehicles and stations queries #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
testower
commented
Sep 9, 2024
| maximumLongitude | ||
| ) | ||
| ) { | ||
| var boundingBoxQueryParameters = new BoundingBoxQueryParameters(); |
There was a problem hiding this comment.
consider validation
There was a problem hiding this comment.
might deal with it in a follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds bounding box search functionality to vehicles and stations queries.
It should be noted that this method is not quicker than using radius, because the implementation must first do the radius search and do post-filtering. There is also some overhead in calculating the circle.
Closes #525
Unit tests
Added integrationt tests
Documentation
Documentation added to graphql schema. geometric functionality documented in code