fix: Fixed spec parser and improved debug, warning and error messages #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnturWilhelm
changed the title
cvaskinn
reviewed
Oct 16, 2024
.github/workflows/code-scan.yml
Outdated
| @@ -334,7 +334,7 @@ jobs: | |||
| except IOError: | |||
| pass | |||
| if allowlist == False: | |||
| print(f'::notice ::Allowlist file not found') | |||
| print(f'::notice ::Local allowlist file not found, skipping remaining steps') | |||
There was a problem hiding this comment.
Kan vi skrive "Allowlist not found in current respository" eller noe i den duren?
cvaskinn
requested changes
Oct 16, 2024
.github/workflows/code-scan.yml
Outdated
| @@ -436,12 +434,10 @@ jobs: | |||
| with open(os.path.join(_file_location, 'external_codescan.yml'), 'r') as f: | |||
| data = yaml.safe_load(f) | |||
| except IOError: | |||
| print('::error ::External allowlist file not found') | |||
| print('::error ::External allowlist file not found, this should not ever happen') | |||
There was a problem hiding this comment.
"This should not happen" er kanskje litt forvirrende.
Kunne teksten vært "local copy of external allowlist not found."
.github/workflows/docker-scan.yml
Outdated
| @@ -159,13 +159,11 @@ jobs: | |||
| except IOError: | |||
| pass | |||
| if data == '': | |||
| print('::error ::Allowlist file not found') | |||
| print('::error ::Local allowlist file not found') | |||
There was a problem hiding this comment.
"No allowlist found in this repository"
.github/workflows/docker-scan.yml
Outdated
| @@ -174,12 +172,10 @@ jobs: | |||
| with open(os.path.join(_file_location, 'external_dockerscan.yml'), 'r') as f: | |||
| data = yaml.safe_load(f) | |||
| except IOError: | |||
| print('::error ::External allowlist file not found') | |||
| print('::error ::External allowlist file not found, this should not ever happen') | |||
There was a problem hiding this comment.
"This should not happen" er kanskje litt forvirrende.
Kunne teksten vært "local copy of external allowlist not found."
cvaskinn
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SIK-1175 and fixes https://entur.slack.com/archives/C02L04S142F/p1729081243019559.