Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute changes #1166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Attribute changes #1166

wants to merge 2 commits into from

Conversation

ntntnlstdnt
Copy link

@ntntnlstdnt ntntnlstdnt commented Oct 23, 2022 •
edited
Loading

  1. Accepted and Rejected are now attributes of QtGui.Dialog
  2. Similarly, Ok, Cancel, Yes, No are now attributes of QtGui.QMessageBox

@ntntnlstdnt
Attribute changes
96dac68 
1. `Accepted` and `Rejected` are now attributes of `QtGui.Dialog`
2. Similarly, Ok, Cancel, Yes, No are now attributes of `QtGui.QMessageBox`
@corranwebster
Copy link
Contributor

Thanks again for the contribution. A similar comment applies here about ensuring support for multiple Qt backends, including some that aren't yet in out test matrix.

@corranwebster
Copy link
Contributor

Similarly here: I think that the current main branch needs to be merged in to this PR branch before tests will pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntntnlstdnt @corranwebster