Implement option to write output to a file in ec test
#1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
==========================================
- Coverage 82.43% 82.21% -0.22%
==========================================
Files 72 72
Lines 5721 5746 +25
==========================================
+ Hits 4716 4724 +8
- Misses 1005 1022 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mbestavros
force-pushed
the
hacbs-2519
branch
from
aaa1887
to
d10ab70
Compare
lcarva
reviewed
Dec 19, 2023
lcarva
reviewed
Dec 19, 2023
lcarva
reviewed
Dec 19, 2023
|
Not sure if the previous comments were addressed or not. Is this ready for fresh reviews @mbestavros ? |
|
@simonbaird I wasn't able to get |
zregvart
reviewed
Jan 5, 2024
cmd/test/test.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("creating output file: %w", err) | ||
| } | ||
| } | ||
| fmt.Printf("%s\n", reportOutput) |
There was a problem hiding this comment.
Just noticed we're not using cmd.OutOrStdout() here, we should, could be in a followup PR as this wasn't added here.
cmd/test/test.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("copying output file to stdout: %w", err) | ||
| } | ||
| fmt.Println(string(contents)) |
There was a problem hiding this comment.
I think we want to use cmd.OutOrStdout() here
Suggested change
| fmt.Println(string(contents)) | |
| fmt.Fprintln(cmd.OutOrStdout(), string(contents)) |
mbestavros
force-pushed
the
hacbs-2519
branch
2 times, most recently
from
fa941d9
to
37cab1d
Compare
lcarva
reviewed
Jan 8, 2024
Signed-off-by: Mark Bestavros <[email protected]>
lcarva
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to
ec testto allow output to a file. Users can use the new option withec test ... --file <file path>.The PR utilizes new functionality available in Conftest
0.47to write Conftest output to a file.Resolves EC-55.