Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Event Online #9930 #9941

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Content Event Online #9930 #9941

wants to merge 11 commits into from

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented Dec 20, 2022

No description provided.

final ImmutableMap.Builder<String, String> builder = ImmutableMap.<String, String>builder()
.put( "id", content.getId().toString() )
.put( "path", content.getPath().toString() )
.put( "repo", ContextAccessor.current().getRepositoryId().toString() );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use context fore repoId

.put( "repo", ContextAccessor.current().getRepositoryId().toString() );

final ContentPublishInfo publishInfo = content.getPublishInfo();
if ( publishInfo != null )
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for example. Not needed in final version

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 84.04% // Head: 84.02% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (53accb6) compared to base (c5ea1d7).
Patch coverage: 88.24% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #9941      +/-   ##
============================================
- Coverage     84.04%   84.02%   -0.03%     
+ Complexity    19272    19261      -11     
============================================
  Files          2583     2583              
  Lines         67729    67715      -14     
  Branches       5449     5441       -8     
============================================
- Hits          56926    56897      -29     
- Misses         8090     8115      +25     
+ Partials       2713     2703      -10     
Impacted Files Coverage Δ
.../main/java/com/enonic/xp/node/PushNodeEntries.java 0.00% <ø> (-80.00%) ⬇️
...tent/AbstractCreatingOrUpdatingContentCommand.java 88.37% <ø> (-1.43%) ⬇️
...nic/xp/core/impl/content/CreateContentCommand.java 86.11% <0.00%> (-0.29%) ⬇️
.../enonic/xp/core/impl/content/GetBinaryCommand.java 80.00% <ø> (+16.00%) ⬆️
...ic/xp/core/impl/content/GetContentByIdCommand.java 90.00% <ø> (-1.67%) ⬇️
...l/content/GetContentByPathAndVersionIdCommand.java 100.00% <ø> (ø)
.../xp/core/impl/content/GetContentByPathCommand.java 100.00% <ø> (ø)
.../xp/core/impl/content/ReprocessContentCommand.java 0.00% <0.00%> (ø)
...nic/xp/core/impl/content/UpdateContentCommand.java 81.28% <ø> (-1.48%) ⬇️
...m/enonic/xp/repo/impl/SingleRepoStorageSource.java 100.00% <ø> (ø)
... and 88 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant