Linter errors after turning on strict mode #10719
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10719 +/- ##
=========================================
Coverage 84.55% 84.55%
Complexity 19977 19977
=========================================
Files 2633 2633
Lines 69316 69316
Branches 5596 5596
=========================================
Hits 58611 58611
Misses 8002 8002
Partials 2703 2703 ☔ View full report in Codecov by Sentry. |
ComLock
requested changes
Oct 2, 2024
| path?: string | string[]; | ||
| } | ||
|
|
||
| interface Portal { |
There was a problem hiding this comment.
Why not use the types from the source, which is available in the same code repo?
ComLock
reviewed
Oct 2, 2024
| @@ -65,7 +65,7 @@ class ResourceImpl | |||
| private res: JavaResource; | |||
|
|
|||
| constructor(key: string | ResourceKey) { | |||
| this.res = bean.getResource(key); | |||
| this.res = bean.getResource(key) ; | |||
anatol-sialitski
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.