fix (build): Remove un-used (and bad) enable-preview (fixes #511 ?) #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a_toolchain (fixes enola-dev#511 ?)
|
OK, this passed on CI - it seems to work without this. JUST to be 101% extra sure, because even though Bazel is normally great about, I'm exceptionally going to wipe out the 1.5 GB Bazel cache on CI - and retrigger a build... if it still works even with this removed, I'll merge this. |
|
OK, so in 2nd rebuild, with now (obviously) 0s instead of 24s in of Cache Bazel fetching, but 6m 41s instead of 1m 49s for the (now full -rebuild, without cache), it clearly also still works, even without this. I'm therefore comfortable to merge this as-is already, and hope it helps for #511 (which is still to be confirmed; if it does not, then I see no harm in still cleaning this up, for now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping that this may fix #511 ...