date handling #1504
Merged
date handling #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eandre
commented
Oct 18, 2024
eandre
commented
- runtimes/{core,js}: refactor schema encode/decode
- Add date support
|
All committers have signed the CLA. |
fredr
reviewed
Oct 22, 2024
Introduce a pair of types, `PValue` and `PValues`. The types allow us to introduce dedicated semantic types that go beyond plain JSON types. As a result, since the wire protocol is still JSON, decoding JSON into these types requires an API schema (so that we know e.g. whether a string is "just a string" or should be a datetime. This commit introduces the concept and refactors the runtimes to use it. The next commit adds support for dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.