Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init for ls pins to mimic behaviour of standard machine.pin #174

Closed
wants to merge 1 commit into from

Conversation

emericklaw
Copy link
Contributor

Description

This now better mimics the way standard machine.pins are initiated.
Also added checks when setting value to only apply to OUT pins.

@kliment
Copy link
Contributor

kliment commented Jun 24, 2024

Hello, and thank you for doing this!

Some related work is happening in #166 (and 133 before it, which 166 is a history-cleanup of) that should hopefully also make the external GPIO API-compatible. We would really like to move the gpio driver entirely out of Python so we can use it from the system libraries that are written in C, and once that is done the changes proposed here should, as far as we can see, no longer be necessary. Can you check whether this assumption is correct, and whether there's something missing from 166 that is present here? If not, the best way forward is probably to close this as a duplicate, but we wanted to get your input before doing so.

@emericklaw
Copy link
Contributor Author

Yes it looks like #166 should do the same.

@emericklaw emericklaw closed this Jun 25, 2024
@MatthewWilkes MatthewWilkes mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants