ProposalC3VOCPublishingWebhook: add option to set thumbnail as well (and test naming) #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russss
approved these changes
Sep 1, 2024
russss
approved these changes
Sep 1, 2024
jayaddison
reviewed
Sep 1, 2024
jayaddison
reviewed
Sep 1, 2024
| path = payload["voctoweb"]["thumb_path"] | ||
| if path.startswith("/static.media.ccc.de"): | ||
| path = "https://static.media.ccc.de/media" + path[len("/static.media.ccc.de"):] | ||
| if not path.startswith("https://"): |
There was a problem hiding this comment.
Are other CDNs likely to be used to host these thumbnails? (just wondering about the broader URI acceptance logic in this case)
There was a problem hiding this comment.
This URL has changed in the past (some time ago it was cdn.c3voc.de i think). I don't think this will change in the future though, so we could have implemented stricter checking here, you're right.
There was a problem hiding this comment.
Thanks, OK! For consistency and safety, I think it makes sense to check the complete domain in that case too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and better test naming