[proposal view] Add video recording host hyperlinks. #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
commented
Jul 14, 2024
jayaddison
commented
Jul 14, 2024
|
Based on local testing, this appears to be working fine. The layout / design doesn't seem ideal to me, so perhaps someone could suggest improvements, but it does function. Screenshot (with empty video object) |
marksteward
force-pushed
the
issue-1259/schedule-item-view-add-video-recording-urls
branch
from
b310430
to
191b2cc
Compare
marksteward
force-pushed
the
issue-1259/schedule-item-view-add-video-recording-urls
branch
from
191b2cc
to
a47e1e3
Compare
Jonty
reviewed
Aug 16, 2024
russss
approved these changes
Aug 18, 2024
russss
deleted the
issue-1259/schedule-item-view-add-video-recording-urls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #1259 we're going to email speakers when their edited video recordings from EMF are first published, and in the emails we're going to link to the proposal view page on the emfcamp.org website.
To make it easier for speakers and viewers to locate the origin hosted copies of the recordings, we should include direct links to each platform (currently CCC, YouTube) on the proposal view.
Note: untested because I don't currently have a functional local dev env (any help testing this is appreciated!)