Add content note and video privacy information to feeds #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edk0
force-pushed
the
video-privacy-and-content-note-in-feeds
branch
from
f20b3ad
to
69083a6
Compare
lukegb
reviewed
Jun 1, 2024
apps/schedule/feeds.py
Outdated
| @@ -35,10 +42,12 @@ def _format_event_description(event): | |||
| if event["map_link"]: | |||
| venue_str = f'{venue_str} ({event["map_link"]})' | |||
| footer_block.append(f'Venue: {venue_str}') | |||
| if event["type"] in ("talk", "lightning talk", "performance") and event["video_privacy"] != "public": | |||
There was a problem hiding this comment.
Is the type actually lightning talk at this point, or is it lightningtalk.
marksteward
requested changes
Jun 1, 2024
|
Lightning talks are untestable here and I only really added them because they made conceptual sense; they don't appear in the schedule afaik. Also I can't test performances because I can't make them recordable locally, did we do that via the db? Anyway I fixed the type thing in theory, and it still looks ok for talks. |
edk0
force-pushed
the
video-privacy-and-content-note-in-feeds
branch
2 times, most recently
from
f653130
to
7f328fe
Compare
edk0
force-pushed
the
video-privacy-and-content-note-in-feeds
branch
from
7f328fe
to
6499dbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been annoying me that these aren't there