Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CfP tags #1295

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Add CfP tags #1295

merged 7 commits into from
Jan 4, 2024

Conversation

SamLR
Copy link
Member

@SamLR SamLR commented Dec 22, 2023

This adds tags to the CfP.

Currently they're added via a basic text box in the cfp admin update-proposal view.

Later PRs will add some nicer auto-complete/suggest functionality as well as view-by/filter-by tag tech.

apps/cfp_review/base.py Outdated Show resolved Hide resolved
models/cfp_tag.py Show resolved Hide resolved
@SamLR
Copy link
Member Author

SamLR commented Dec 24, 2023

see #678

@SamLR SamLR force-pushed the cfp-tags branch 2 times, most recently from d15eb87 to 08756d2 Compare December 24, 2023 02:44
@SamLR
Copy link
Member Author

SamLR commented Dec 24, 2023

I've tried (very lazily) to tame the proposal update form by putting the whole thing into an accordion. It's really shitty UI but it at least means you can navigate a little quicker. Might be possible to improve it by replacing the heading with summary of any set values in the section but that's a bit more than I feel like implementing right now.

@Jonty any thoughts as you're one of the folks who have interacted with this a lot?

Screenshot 2023-12-24 at 17 56 03

Mostly for tracking which tags have what
We want the cfp tags to be relatively limited so it (should) be fine to
manage them via CLI. If need-be a management page can be added but I'd
like to avoid that for the time being as hopefully they'll be a
one-and-done set up. It's a separate command but I've also hooked it
into the `dev data` command just to make sure there's something there.
@marksteward marksteward merged commit 1155f31 into main Jan 4, 2024
2 checks passed
@marksteward marksteward deleted the cfp-tags branch January 4, 2024 18:54
@SamLR
Copy link
Member Author

SamLR commented Jan 6, 2024

Thanks @marksteward

@SamLR SamLR mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants