Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

payments: update the test IBAN used in the codebase #1293

Merged
merged 1 commit into from
Dec 18, 2023
Merged

payments: update the test IBAN used in the codebase #1293

merged 1 commit into from
Dec 18, 2023

Conversation

jayaddison
Copy link
Contributor

The existing test fixture didn't pass IBAN check-digit validity:

>> from stdnum import iban
>>> iban.is_valid('GB47LOND11213141516171')
False
>>> iban.is_valid('GB33BUKB20201555555555')
True

The updated test value was sourced from this list of test IBANs.

@marksteward marksteward merged commit 4d956e1 into main Dec 18, 2023
3 checks passed
@marksteward marksteward deleted the test-data/update-test-bank-iban branch December 18, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksteward marksteward marksteward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayaddison @marksteward