Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: icon-border-radius #528

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Samferos
Copy link

Solves #454 though I'm concerned about the fact that I have duplicated code with the rounded_square function in icon.c where it basically achieves the same purpose as the set_rounded_rectangle in render.c.

@Samferos Samferos marked this pull request as draft August 12, 2024 11:14
@Samferos
Copy link
Author

Samferos commented Aug 12, 2024

not only that, the cmdline argument for the icon-border-radius isn't working
only works through config file right now
seems like i didn't read the codebase enough

@Samferos
Copy link
Author

Comparison :
icon-border-radius=0
image
icon-border-radius=20
image

@Samferos Samferos marked this pull request as ready for review August 28, 2024 09:46
@Samferos Samferos marked this pull request as draft September 6, 2024 08:51
(otherwise icons got clipped when it was zero)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant