Update triggerEvent & triggerKeyEvent target type #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include `Document` in the target argument type, as it's already included in the code. https://github.com/emberjs/ember-test-helpers/blob/880272edf6475ddd05f2c2c2e39efb7db9cf2578/addon-test-support/%40ember/test-helpers/dom/-get-element.ts#L6
8 tasks
|
Thank you! |
stefanpenner
requested changes
Aug 17, 2021
| @@ -1205,3 +1205,5 @@ Returns **([Array][68]\<Warning> | [Promise][64]<[Array][68]\<Warning>>)** An ar | |||
| [75]: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode | |||
|
|
|||
| [76]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/function | |||
|
|
|||
| [77]: https://developer.mozilla.org/en-US/docs/Web/API/Document | |||
There was a problem hiding this comment.
Was this change generated by yarn run docs? If not, we likely need to investigate why yarn run docs isn't producing this change, as API.md is an artifact of that build step
There was a problem hiding this comment.
@stefanpenner I was asked to update the docs before merging this Definitely Typed PR: DefinitelyTyped/DefinitelyTyped#55123
I've never contributed to this repo before and I made these changes manually. I tried running yarn run docs and it removed all of my changes. What do I need to do to make this change mergeable?
|
@stefanpenner thoughts on merging this and then fixing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
Documentin the target argument type fortriggerEventandtriggerKeyEvent, as it's already included in the TS code.ember-test-helpers/addon-test-support/@ember/test-helpers/dom/-get-element.ts
Line 6 in 880272e
Once this Docs PR is merged, we'll merge this DefinitelyTyped PR DefinitelyTyped/DefinitelyTyped#55123 since this repo is not publishing types yet.