Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply website redesign #152

Merged
merged 6 commits into from
Jun 16, 2020

Conversation

jayjayjpg
Copy link
Contributor

@jayjayjpg jayjayjpg commented Apr 29, 2020

Closes #150

Review the new layout over at https://deploy-preview-152--ember-help-wanted.netlify.app/ or by checking out this feature branch locally.

@MelSumner
Copy link
Member

@jayjayjpg could you update the branch? And, do you need any additional help to move this out of draft?

@jayjayjpg jayjayjpg marked this pull request as ready for review June 13, 2020 12:28
@jayjayjpg jayjayjpg force-pushed the apply-website-redesign branch 3 times, most recently from 440a20f to ee703cb Compare June 13, 2020 13:22
@jayjayjpg jayjayjpg requested a review from a team June 13, 2020 13:56
@jayjayjpg
Copy link
Contributor Author

@MelSumner Thank you for the nudge! I just updated the feature branch and it should be ready for review over at Netlify (and for testing the issues sub route, it's best to test locally)

Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this happen! 👍

@MelSumner
Copy link
Member

@jayjayjpg I noticed in the netlify preview that the issues themselves aren't showing up like they are on the current site published to production. Is that an in-progress glitch?

@jayjayjpg
Copy link
Contributor Author

@MelSumner That's correct and I just had another look at the CORS settings for the backend on Heroku, which needed an update to accommodate for a new url scheme on netlify previews apps it seems. I think this should resolve the issue now: (https://deploy-preview-152--ember-help-wanted.netlify.app/learning)

If something else is missing, feel free to let me know and I can investigate! And thank you for taking the time to review in the first place 🙇‍♀️

@MelSumner
Copy link
Member

Ahh perfect. It looks great, thank you for working on this!

@MelSumner MelSumner merged commit 21e6312 into ember-learn:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply Website Redesign
2 participants