Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop requesting mappings over the network and fix shoebox usage #923

Merged
merged 3 commits into from
Jul 24, 2024
Merged

stop requesting mappings over the network and fix shoebox usage #923

merged 3 commits into from
Jul 24, 2024

Commits on Jul 23, 2024

  1. stop requesting mappings over the network 

    for some reason we're requesting the mappings.json file on every initial page load (and not cached in the shoebox). This is in the application afterModel hook so there is no chance that we will ever not make this request, so it's worth just backing the json into the JS bundle to save a request
    @mansona
    mansona committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7438dbc View commit details
    Browse the repository at this point in the history

  2. fix shoebox usage

    @mansona
    mansona committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b260172 View commit details
    Browse the repository at this point in the history

  3. fix tests using peekRecord with upper-case ids

    @mansona
    mansona committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fc64a22 View commit details
    Browse the repository at this point in the history