Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API docs redesign anchor #887

Merged
merged 9 commits into from
Sep 11, 2023
Merged

API docs redesign anchor #887

merged 9 commits into from
Sep 11, 2023

Conversation

lukasnys
Copy link

@lukasnys lukasnys commented Sep 10, 2023 •
edited
Loading

Fixes #882

More concretely:

Normal Hover
image image

Lukas Nys added 2 commits September 10, 2023 15:31
remove now irrelevant test (ember-learn#882)
815b8b5 
we're no longer hiding the link icon until the header is hovered, which makes this test irrelevant
move class-field-description--link class to correct element (ember-le…
a87910e 
…arn#882)
@lukasnys lukasnys marked this pull request as ready for review September 10, 2023 14:00
@lukasnys
Copy link
Author

I think it might make sense to create an additional ticket on https://github.com/orgs/ember-learn/projects/72/ to move the link svg styling to ember-styleguide

MinThaMie
MinThaMie approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@MinThaMie MinThaMie merged commit 4937d34 into ember-learn:website-redesign Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinThaMie MinThaMie MinThaMie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasnys @MinThaMie