-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prember #815
Merged
Use prember #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
✅ Deploy Preview for ember-api-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mansona
force-pushed
the
prember
branch
2 times, most recently
from
April 28, 2023 16:17
9a6653b
to
9b91558
Compare
mansona
force-pushed
the
prember
branch
2 times, most recently
from
May 22, 2023 15:11
5445043
to
7432c81
Compare
Freshly rebased |
jaredgalanis
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project board: https://github.com/orgs/ember-learn/projects/68/views/1
We aim to use prember to build the docs site, eliminating the need for a back end server. We also aim to store docs json in git instead of S3, which means we can edit those docs by hand when needed, fix broken URLs, etc. and not have to run new releases to do so.
It is less work if we do this with git and not worry about shipping it for the old json docs. The reason is we can clone the git repo easily in order to get the data prember needs, instead of fetching a zillion things from s3
To update the local branch so that it contains the json docs, use
npm run clone
. Otherwise see an error about a directory not existing.