Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prember #815

Merged
merged 26 commits into from
Sep 22, 2023
Merged

Use prember #815

merged 26 commits into from
Sep 22, 2023

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Aug 5, 2022

Project board: https://github.com/orgs/ember-learn/projects/68/views/1

We aim to use prember to build the docs site, eliminating the need for a back end server. We also aim to store docs json in git instead of S3, which means we can edit those docs by hand when needed, fix broken URLs, etc. and not have to run new releases to do so.

It is less work if we do this with git and not worry about shipping it for the old json docs. The reason is we can clone the git repo easily in order to get the data prember needs, instead of fetching a zillion things from s3

To update the local branch so that it contains the json docs, use npm run clone. Otherwise see an error about a directory not existing.

@chriskrycho chriskrycho mentioned this pull request Nov 18, 2022
@jenweber jenweber mentioned this pull request Nov 19, 2022
9 tasks
@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for ember-api-docs ready!

Name Link
🔨 Latest commit ab36313
🔍 Latest deploy log https://app.netlify.com/sites/ember-api-docs/deploys/650d62cf25f8e30009f18b05
😎 Deploy Preview https://deploy-preview-815--ember-api-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jenweber
Copy link
Contributor Author

Freshly rebased

@mansona mansona changed the title WIP use prember Use prember Sep 21, 2023
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mansona mansona merged commit 9036613 into master Sep 22, 2023
2 checks passed
@mansona mansona deleted the prember branch September 22, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants