Capabilities document and cleanup #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving CapabilitiesList, we can take advantage of the existing build
system for building and running CapabilitiesList.
The downside of this approach is that we still need all libraries JSS
depends on to be present for running.
This is made easy by run_test.sh (templated under build/):
cd build && ./run_test org.mozilla.jss.tests.CapabilitiesList
Note that this gives the warning:
WARNING: JSS provider is already installed
In order to suppress this warning, the line:
export JAVA_SECURITY_CFG="...some/path..."
can be overwritten with the empty string:
export JAVA_SECURITY_CFG=""
and the utility run. However, JSS will not automatically load as a
result of the java.security provider properties listing.
Signed-off-by: Alexander Scheel <[email protected]>
This fixes a bug in the verbose listing: startswith is case-sensitive
and aliases begin with "Alg.Alias." not "Alg.alias" as presently
searched for.
Additionally, we update the verbose listing to nest aliases under the
respective "core" implementation heading. Both the implementation and
alias listings have been sorted, to be stable across multiple runs.
The new output of a verbose listing looks roughly like so:
AlgorithmParameters : IvAlgorithmParameters
AlgorithmParameters : RC2AlgorithmParameters
AlgorithmParameters : RSAPSSAlgorithmParameters
Cipher : AES
Cipher : DES
Cipher : DESede
Alias: Cipher.DES3
Cipher : RC2
Cipher : RC4
Cipher : RSA
KeyFactory : DSA
KeyFactory : EC
KeyFactory : RSA
KeyGenerator : AES
KeyGenerator : DES
KeyGenerator : DESede
Alias: KeyGenerator.DES3
Signed-off-by: Alexander Scheel <[email protected]>
By moving CapabilitiesList, we can take advantage of the existing build
system for building and running CapabilitiesList.
The downside of this approach is that we still need all libraries JSS
depends on to be present for running.
This is made easy by run_test.sh (templated under build/):
cd build && ./run_test.sh org.mozilla.jss.tests.CapabilitiesList
Note that this gives the warning:
WARNING: JSS provider is already installed
In order to suppress this warning, the line:
export JAVA_SECURITY_CFG="...some/path..."
can be overwritten with the empty string:
export JAVA_SECURITY_CFG=""
and the utility run. However, JSS will not automatically load as a
result of the java.security provider properties listing.
Signed-off-by: Alexander Scheel <[email protected]>
Capabilities: use CMake build
Change output of Verbose Capabilities listing to nest Aliases
- some of it was adapted from Alex Sheel comments on issue dogtagpki#693 see dogtagpki#693
Co-authored-by: Alexander Scheel <[email protected]>
Co-authored-by: Alexander Scheel <[email protected]>
- needed since CapabiltiesList was moved to become a test
|
Closed to resubmit with the proper branch to merge into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of the changes need for dogtagpki#693