Add a checked property on checkbox. Close #693. #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are there any concerns or feedback regarding this PR that is preventing it from being merged? I've resorted to forking and merging a few of these open PR's and IMO this one in particular is quite essential. check boxes aren't very useful without the ability to maintain state. |
|
mmm I believe for quite a long time there was no activity on the project, and that might be the main reason why this PR wasn't looked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a checked property on the checkbox widget. Also closes issue #693.
Usage
Usage is straightforward:
(checkbox :checked true ...)Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/maindirectory has been adjusted to reflect my changes. NOTICE: I think I have nothing to add to the files in docs, am I right?cargo fmtto automatically format all code before committing