-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Let In Syntax Initial Impl #578
base: master
Are you sure you want to change the base?
Conversation
@@ -91,6 +91,9 @@ impl SimplExpr { | |||
.collect::<Result<_, _>>()?, | |||
), | |||
x @ Literal(..) => x, | |||
LetIn(_, d, b) => { | |||
todo!("Resolve Refs is unused, TODO(josiah)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear to me atm what should be done here. As far as I can tell the function is (transitively) unused, and could be removed, so it might not be a problem.
It might make the most sense to use the values from the let block to map the inner vars, but the variable defs haven't been evaluated yet here.
98140f9
to
98e6c43
Compare
@elkowar Just following up here to see if you have any feedback on the direction of this? Specifically if |
Description
This is not intended to be final, but I had some time so I thought I would work on this. First pass ended up being easier than I was expecting.
true
andfalse
within idents, so long as it is not the entire thing.Usage
Showcase
My current workspace indicator:
Where I have a script that outputs the following on workspace changes:
And the let-in syntax to pull out the relevant information for each part
Diffs containing fuller example of usage
Additional Notes
I borrowed the testing macro from #577
Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/main
directory has been adjusted to reflect my changes.cargo fmt
to automatically format all code before committing