Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support empty string for safe access operator #1176

Merged
merged 9 commits into from
Oct 12, 2024

Conversation

w-lfchen
Copy link
Contributor

@w-lfchen w-lfchen commented Aug 27, 2024

Description

Additional Notes

This contains the breaking change of no longer supporting safe access for JSON strings (noted in the changelog).

Checklist

  • I added my changes to CHANGELOG.md, if appropriate.
  • The documentation in the docs/content/main directory has been adjusted to reflect my changes.
  • I used cargo fmt to automatically format all code before committing

Copy link
Contributor Author

@w-lfchen w-lfchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dropped the dependency updates, that should be done in a separate pr alongside updating to rust 1.81

@elkowar
Copy link
Owner

elkowar commented Oct 11, 2024

I think the breaking change regarding json strings definitely needs to be mentioned in the changelog, but I think conceptually it makes sense this way.

@elkowar elkowar merged commit 50ec181 into elkowar:master Oct 12, 2024
1 check passed
@w-lfchen w-lfchen deleted the feat/safe_access branch October 12, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect handling of an empty string by the safe access operator
2 participants