Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use clippy; abort run on failure #1171

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

w-lfchen
Copy link
Contributor

@w-lfchen w-lfchen commented Aug 26, 2024

Description

current state:

  • clippy is installed in ci but never invoked
  • cargo check is executed to check for warnings, but no actionis taken if some exist.

this pr changes both of these things.
clippy is used and if there is a warning or a lint, ci fails.

Additional Notes

  • ci should fail for the first commit, i'll push a fix once that happened (worked as expected).
  • it might be worth splitting up things in the workflows so that they can run in parallel.
  • i am against ci modifying code.
  • i might look into applying some changes from Add Test runs to CI, don't run gh-pages from forks #590

Checklist

  • I added my changes to CHANGELOG.md, if appropriate.
    i don't think this applies here
  • I used cargo fmt to automatically format all code before committing

CARGO_TERM_COLOR: always

CARGO_TERM_COLOR: always
RUSTFLAGS: "-Dwarnings"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed to fail ci, see the clippy ci docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant