Added the junit test cases for CustomAuthorizationInterceptor #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsinghht
changed the title
vsinghht
changed the title
shubhamparikh927
approved these changes
Aug 29, 2023
hankwallace
requested changes
Aug 29, 2023
| @@ -87,7 +87,7 @@ private List<IAuthRule> unauthorizedRule() { | |||
| .build(); | |||
| } | |||
|
|
|||
| private List<IAuthRule> authorizeOAuth(RequestDetails theRequest) throws AuthenticationException { | |||
| protected List<IAuthRule> authorizeOAuth(RequestDetails theRequest) throws AuthenticationException { | |||
There was a problem hiding this comment.
No - tests shouldn't require changes to the underlying methods.
hankwallace
requested changes
Aug 29, 2023
…r-jpaserver-starter into junit-tests-for-CustomAuthorizationInterceptor
hankwallace
requested changes
Oct 19, 2023
| private static final String ROLE_INVALID_USER = "invalid-user"; | ||
|
|
||
| @BeforeEach | ||
| public void before() throws IOException { |
There was a problem hiding this comment.
Why would a before() throw an exception?
hankwallace
reviewed
Oct 19, 2023
| private static Server ourServer; | ||
| private static final FhirContext ourCtx = FhirContext.forR4(); | ||
|
|
||
| private static final String TOKEN = "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiYWRtaW4iOnRydWUsImlhdCI6MTUxNjIzOTAyMn0.NHVaYe26MbtOYhSKkoKYdFVomg4i8ZJd8_-RU8VNbftc4TSMb4bXP3l3YlNWACwyXPGffz5aXHc6lty1Y2t4SWRqGteragsVdZufDn5BlnJl9pdR_kdVFUsra2rWKEofkZeIC4yWytE58sMIihvo9H1ScmmVwBcQP6XETqYd0aSHp1gOa9RdUPDvoXQ5oqygTqVtxaDr6wUFKrKItgBMzWIdNZ6y7O9E0DhEPTbE9rfBo6KTFsHAZnMg4k68CDp2woYIaXbmYTWcvbzIuHO7_37GT79XdIwkm95QJ7hYC9RiwrV7mesbY4PAahERJawntho0my942XheVLmGwLMBkQ"; |
There was a problem hiding this comment.
Why is there a single hard-coded token?
There was a problem hiding this comment.
This is test token we have return below, as
DecodedJWT jwt = JWT.decode(token);
method in CustomAuthorizationInterceptor requires a valid JWT to decode or we should mock this method as well.
…r-jpaserver-starter into junit-tests-for-CustomAuthorizationInterceptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
How it was tested
Checklist