Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and bug Fixes #119

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

jeffdrumgod
Copy link

No description provided.

removed duplicate info about version
Now there is a class on the element used to display the loading tag.
With this we subtract a few bytes of the JS file, and user must
configure the CSS in your project stylesheet.
Added new option "attrImageZoomSrc". Attribute src image zoom now is
dynamic
When we changed the image, clicking on the thumb, the tag <div> spinner
was doubled every click.
Removed -webkit-transform: translateZ(0); to improve compability.
@igorlino
Copy link

@jeffdrumgod interesting changes, thanks a lot
I added a fix for the spinner, otherwise there is an exception.
The loadingIcon I use a different approach, perhaps later on I would extract that CSS, but it already had a CSS class.

Everything under the latest of https://github.com/igorlino/elevatezoom-plus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants