Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to skip TLS verification for outgoing matrix client connections #18

Merged
merged 4 commits into from
Apr 27, 2024
Merged

add option to skip TLS verification for outgoing matrix client connections #18

merged 4 commits into from
Apr 27, 2024

Conversation

fkwp
Copy link
Contributor

@fkwp fkwp commented Apr 24, 2024 •
edited
Loading

fixes #14

@fkwp fkwp requested a review from AndrewFerr April 24, 2024 20:28
AndrewFerr
AndrewFerr previously approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and tested locally to confirm that it works. I just left a few optional suggestions.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
fkwp and others added 2 commits April 26, 2024 15:12
@fkwp @AndrewFerr
cleanup log line
3de9c0f 
Co-authored-by: Andrew Ferrazzutti <[email protected]>
@fkwp @AndrewFerr
simplify branch
9460f29 
Co-authored-by: Andrew Ferrazzutti <[email protected]>
@fkwp fkwp requested a review from AndrewFerr April 26, 2024 14:11
@fkwp fkwp merged commit 4a29504 into main Apr 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Allow invalid TLS certificates for debugging (InsecureSkipVerify)
2 participants
@fkwp @AndrewFerr