Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a verification badge on the Room Member/User Profile screens. #3427

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Show a verification badge on the Room Member/User Profile screens. #3427

wants to merge 3 commits into from
+504 −111

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 18, 2024 •
edited
Loading

This PR makes 2 changes to the Room Member and User Profile screens:

  • Show a verified badge when verified.
  • Show a disabled Verify button when the user isn't verified.

Requires matrix-org/matrix-rust-sdk#4142, closes #3413

Verified Unverified
test_roomMemberDetailsScreen-iPhone-16-en-GB Verified-User test_roomMemberDetailsScreen-iPhone-16-en-GB Other-User

@pixlwave pixlwave requested a review from a team as a code owner October 18, 2024 12:54
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 18, 2024 12:54
@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 18, 2024
@pixlwave pixlwave changed the title Doug/verified status Show a verification badge on the Room Member/User Profile screens. Oct 18, 2024
@github-actions GitHub Actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 599574e

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu Awaiting requested review from stefanceriu stefanceriu is a code owner automatically assigned from element-hq/element-x-ios-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr-change for updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Show in user's profile when they have been verified
1 participant
@pixlwave