Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin paparazzi to v1.3.5 #3826

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 7, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
app.cash.paparazzi 1.3.4 -> 1.3.5 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

cashapp/paparazzi (app.cash.paparazzi)

v1.3.5

Compare Source

New
  • Render pending recompositions for @Composables that require a second layout pass
  • Support for overlays in accessibility snapshots
  • Support for Compose UI heading and selected states in accessibility snapshots
  • Support for toggleable state in accessibility snapshots
  • Support for displaying multiple accessibility descriptions, similar to Talkback
  • Include failure delta image in JUnit test reporting
  • Migrate Paparazzi to layoutlib Jellyfish 2023.3.1
  • Compose 1.7.5
  • Kotlin 2.0.21
  • [Gradle Plugin] Gradle 8.10.2
  • [Gradle Plugin] Android Gradle Plugin 8.4.2
Fixed
  • Improve Gradle test task caching by preventing overlapping outputs with snapshotOutputDir
  • Migrate plugin to use modern AGP variant APIs
  • Fix support for AndroidX ResourcesCompat.getFont()
  • Fix inconsistent cross-platform text renderings in failure delta image
  • Relax image comparisons with OffByTwo differ to work around cross-platform rendering issues
  • Fix when clearAndSetSemantics is used to render content descriptions in accessibility snapshots
  • Avoid invalid chars in Windows filenames
  • Fix file move failures on Windows
  • Avoid hash collisions when images have similar RGB content
  • Cleanup unnecessary "loadPublicResourceNames" warning from log output
  • Additional bug fixes with accessibility snapshot tests

Kudos to @​geoff-powell, @​colinmarsch, @​BrianGardnerAtl, @​ribafish, @​gabrielittner and others for contributions this release!


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner November 7, 2024 10:36
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Nov 7, 2024
@renovate renovate bot requested review from jmartinesp and removed request for a team November 7, 2024 10:36
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Dd45LM

@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 7, 2024
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (213dc77) to head (0b75cd1).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3826      +/-   ##
===========================================
+ Coverage    82.98%   83.00%   +0.02%     
===========================================
  Files         1782     1782              
  Lines        44860    44860              
  Branches      5265     5265              
===========================================
+ Hits         37228    37237       +9     
+ Misses        5793     5789       -4     
+ Partials      1839     1834       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp
Copy link
Member

It seems like the new version affected how blooms and shadows are rendered, as well as transforming whitespace in file names to _, but otherwise I think everything is ok. @bmarty could this affect the EXA gallery?

@bmarty
Copy link
Member

bmarty commented Nov 7, 2024

  • For Gallery I think it's going to be fine. Else we will have to fix the script, but we can handle it if necessary. Looks like it's using the PreviewGroup name, for instance this one, and replace the space with _ as you said.
  • The preview for BottomSheet seems better (we can now see the content below)
  • Also for the Bloom how do you explain the diff?
image

@jmartinesp
Copy link
Member

jmartinesp commented Nov 7, 2024

There were some changes in latest Compose versions to how gradients and shadows are rendered so I guess it's that... or layoutlib changed its internal rendering.

FWIW I think in a real device it looks like the new version.

Copy link
Contributor Author

renovate bot commented Nov 7, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jmartinesp jmartinesp merged commit 2386350 into develop Nov 7, 2024
26 checks passed
@jmartinesp jmartinesp deleted the renovate/app.cash.paparazzi-1.x branch November 7, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants