Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: do not remove logs after sending them #3780

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Oct 31, 2024

Content

Do not remove logs after sending them.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Bugfix For bug fix label Oct 31, 2024
@ganfra ganfra marked this pull request as ready for review October 31, 2024 10:43
@ganfra ganfra requested a review from a team as a code owner October 31, 2024 10:43
@ganfra ganfra requested review from bmarty and removed request for a team October 31, 2024 10:43
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fmEHvy

Copy link

sonarcloud bot commented Oct 31, 2024

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (a772f00) to head (7aa1a33).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3780      +/-   ##
===========================================
- Coverage    82.93%   82.93%   -0.01%     
===========================================
  Files         1771     1771              
  Lines        44483    44481       -2     
  Branches      5222     5222              
===========================================
- Hits         36894    36892       -2     
  Misses        5754     5754              
  Partials      1835     1835              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ganfra ganfra enabled auto-merge October 31, 2024 14:05
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 31, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 31, 2024
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ganfra ganfra disabled auto-merge October 31, 2024 19:06
@ganfra ganfra merged commit 21db1fd into develop Oct 31, 2024
31 of 33 checks passed
@ganfra ganfra deleted the feature/fga/logs_fix_removal branch October 31, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants