Enable identity pinning violation notifications unconditionally

[andybalaam]

Content

Enable identity pinning violation notifications unconditionally (remove the feature flag we added when this feature seemed unstable).

Motivation and context

(Internal issue). Part of the Trust and Decorations work.

In #3648 we disabled identity change notifications based on a default-off feature flag, because we found some bugs in the feature. The bugs are fixed and we think it's time to enable the feature unconditionally.

Tests

On a local Synapse, I connected 2 users and changed the identity of one. I verified that, despite not setting any labs flags, the "identity changed" banner appeared.

Tested devices

• Physical
• Emulator
• OS version(s): VanillaIceCream

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes - no UI change
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility - no UI change
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes - no UI changes
• Pull request includes a sign off - I am exempt because I am an Element employee
• You've made a self review of your PR

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

• Your branch should be based on origin/develop, at least when it was created.
• The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
• The test pass locally running ./gradlew test.
• The code quality check suite pass locally running ./gradlew runQualityChecks.
• If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (7358cae) to head (50471f8).
Report is 13 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3745      +/-   ##
===========================================
- Coverage    82.93%   82.92%   -0.02%     
===========================================
  Files         1770     1770              
  Lines        44465    44453      -12     
  Branches      5222     5221       -1     
===========================================
- Hits         36878    36863      -15     
- Misses        5752     5753       +1     
- Partials      1835     1837       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andybalaam]

Test failure looks unrelated, unless I'm missing something?

[bmarty]

Thanks! We have a flaky test, I have re-run the test, it should be fine.

[andybalaam]

@bmarty would you like me to rebase before merging?

[bmarty]

@andybalaam no, you can merge anytime!