Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release script improvement #3741

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Release script improvement #3741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
604dba7
Update instruction
bmarty Oct 25, 2024
5b06680
Give a chance for download_all_github_artifacts.py to fail and to try…
bmarty Oct 25, 2024
8d81b36
Change default value of doBuildApks to "no"
bmarty Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/github/download_all_github_artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import hashlib
import json
import os
# Run `pip3 install requests` if not installed yet
# Run `pip3 install requests --break-system-packages` if not installed yet
import requests
# Run `pip3 install re` if not installed yet
import re
Expand Down
19 changes: 16 additions & 3 deletions tools/release/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,24 @@ targetPath="./tmp/Element/${version}"
printf "\n================================================================================\n"
printf "Downloading the artifacts...\n"

python3 ./tools/github/download_all_github_artifacts.py \
ret=1

while [[ $ret -ne 0 ]]; do
python3 ./tools/github/download_all_github_artifacts.py \
--token "${gitHubToken}" \
--runUrl "${runUrl}" \
--directory "${targetPath}"

ret=$?
if [[ $ret -ne 0 ]]; then
read -p "Error while downloading the artifacts. You may want to fix the issue and retry. Retry (yes/no) default to yes? " doRetry
doRetry=${doRetry:-yes}
if [ "${doRetry}" == "no" ]; then
exit 1
fi
fi
done

printf "\n================================================================================\n"
printf "Unzipping the F-Droid artifact...\n"

Expand Down Expand Up @@ -312,8 +325,8 @@ printf "\n======================================================================
printf "The file ${signedBundlePath} has been signed and can be uploaded to the PlayStore!\n"

printf "\n================================================================================\n"
read -p "Do you want to build the APKs from the app bundle? You need to do this step if you want to install the application to your device. (yes/no) default to yes " doBuildApks
doBuildApks=${doBuildApks:-yes}
read -p "Do you want to build the APKs from the app bundle? You need to do this step if you want to install the application to your device. (yes/no) default to no " doBuildApks
doBuildApks=${doBuildApks:-no}

if [ "${doBuildApks}" == "yes" ]; then
printf "Building apks...\n"
Expand Down
Loading