Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue on canInvite refresh. #3670

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 14, 2024

Content

Better to refresh the value base on the syncUpdateFlow value.

Motivation and context

more reliable can invite.
Was part of #3645

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner October 14, 2024 10:18
@bmarty bmarty requested review from jmartinesp and removed request for a team October 14, 2024 10:18
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hf4WNC

Copy link

sonarcloud bot commented Oct 14, 2024

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (01fb066) to head (e5a8180).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3670   +/-   ##
========================================
  Coverage    82.81%   82.81%           
========================================
  Files         1747     1747           
  Lines        41779    41782    +3     
  Branches      5107     5108    +1     
========================================
+ Hits         34598    34601    +3     
  Misses        5365     5365           
  Partials      1816     1816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 15, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 15, 2024
@bmarty bmarty merged commit b2ea39e into develop Oct 15, 2024
31 checks passed
@bmarty bmarty deleted the feature/bma/fixCanInviteRefresh branch October 15, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants