Try fixing contributor PR notice

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

The if in this flow was never true, so I tried a safer and more manual approach.

Motivation and context

Contributor PR notice wasn't displayed for external PRs anymore.

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

• Your branch should be based on origin/develop, at least when it was created.
• There is a changelog entry in the changelog.d folder with the Towncrier format.
• The test pass locally running ./gradlew test.
• The code quality check suite pass locally running ./gradlew runQualityChecks.
• If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3qPUVG

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4cde9b) 70.07% compared to head (85e7d12) 70.07%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2335   +/-   ##
========================================
  Coverage    70.07%   70.07%           
========================================
  Files         1352     1352           
  Lines        33243    33243           
  Branches      6875     6875           
========================================
  Hits         23296    23296           
  Misses        6633     6633           
  Partials      3314     3314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Thanks!

[bmarty]

The comment does not match the code, there is a swap between base and head, and that was not nice for my head :)

[jmartinesp]

I'll swap the values 😅 .

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud