Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate on the release script and workflow #2324

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 31, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Fix issue on release script, discovered when releasing 0.4.2
  • Add (manual :/) steps to publish the PlayStore (open testing)
  • Update the documentation to install the app from a GitHub release.

Motivation and context

Working script and help release managers and testers

Screenshots / GIFs

NA

Tests

  • We will see during the next release if it works well and may iterate if it's not the case.

Tested devices

NA

Checklist

@bmarty bmarty requested a review from a team as a code owner January 31, 2024 10:19
@bmarty bmarty requested review from jmartinesp and removed request for a team January 31, 2024 10:19
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few minor errors in the instructions, but this can be merged as soon as those are fixed. Thanks!

docs/install_from_github_release.md Outdated Show resolved Hide resolved
docs/install_from_github_release.md Outdated Show resolved Hide resolved
docs/install_from_github_release.md Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 31, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Ef2sGS

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e39711b) 70.05% compared to head (969962f) 70.05%.
Report is 1 commits behind head on develop.

❗ Current head 969962f differs from pull request most recent head 3c182a0. Consider uploading reports for the commit 3c182a0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2324   +/-   ##
========================================
  Coverage    70.05%   70.05%           
========================================
  Files         1353     1353           
  Lines        33233    33233           
  Branches      6872     6872           
========================================
  Hits         23283    23283           
  Misses        6641     6641           
  Partials      3309     3309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Jorge Martin Espinosa <[email protected]>
@bmarty bmarty merged commit 3bbaf7d into develop Jan 31, 2024
12 checks passed
@bmarty bmarty deleted the feature/bma/fixReleaseScript branch January 31, 2024 10:53
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants