Make the whole items in advanced settings screen clickable, standarize paddings

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• Make the whole list items in advanced settings screen clickable, instead of just the switches.
• Makes sure UI components such as radio buttons, switches and checkboxes used inside ListItem components always have the minimum interactive size (48x48dp) to fix screenshot tests discrepancies seen with the changes above.

Sadly, this created more discrepancies, but at least now it's standarized.

Motivation and context

UX issues discovered while testing this screen.

Screenshots / GIFs

There are quite a few in the PR contents.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/CBWZHZ

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5b0268a) 70.08% compared to head (39cd863) 70.09%.
Report is 19 commits behind head on develop.

Files	Patch %	Lines
...m/impl/components/SearchMultipleUsersResultItem.kt	81.81%	0 Missing and 2 partials ⚠️
...s/roomdetails/impl/invite/RoomInviteMembersView.kt	83.33%	1 Missing and 1 partial ⚠️
...libraries/matrix/ui/components/CheckableUserRow.kt	90.90%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2314   +/-   ##
========================================
  Coverage    70.08%   70.09%           
========================================
  Files         1353     1351    -2     
  Lines        33247    33230   -17     
  Branches      6877     6871    -6     
========================================
- Hits         23301    23291   -10     
+ Misses        6638     6633    -5     
+ Partials      3308     3306    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Interesting. I am trying to see what can cause this.

[bmarty]

OK, so I think removing this line will fix this regression. Glad to have screenshot test!

[bmarty]

It will match what we have in CheckableUserRow (which is missing a Preview...)

[jmartinesp]

It should be fixed in 7c794f5.

Let's see the result in the screenshots.

[bmarty]

Now I am wondering if the fix could be to add the padding where it was missing, instead of removing the existing one. The Checkbox are closer to the edge now... Maybe add a 8.dp padding?

Also maybe CheckableUnresolvedUserRow and CheckableUserRow could use a common Composable generic layout.

[jmartinesp]

True, I didn't realise that. The 8dp padding will probably solve it, yes 👍 .

Also maybe CheckableUnresolvedUserRow and CheckableUserRow could use a common Composable generic layout.

I can try to make a common one.

[bmarty]

A small regression to fix, else LGTM. Thanks for working on this!

[bmarty]

Thanks for the update. I do not see any more issue in the screenshot.
Feel free to ignore my last comment.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud