Cleanup and ensure that canUserJoinCall is live. #2313
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2313 +/- ##
===========================================
- Coverage 70.08% 70.08% -0.01%
===========================================
Files 1353 1353
Lines 33247 33246 -1
Branches 6877 6877
===========================================
- Hits 23301 23300 -1
Misses 6638 6638
Partials 3308 3308 ☔ View full report in Codecov by Sentry. |
| @@ -157,9 +155,9 @@ class MessagesPresenter @AssistedInject constructor( | |||
| mutableStateOf(false) | |||
| } | |||
|
|
|||
| LaunchedEffect(currentSessionIdHolder.current) { | |||
| LaunchedEffect(syncUpdateFlow) { | |||
There was a problem hiding this comment.
If you want the check to be done at each sync, you should use syncUpdateFlow.value instead
There was a problem hiding this comment.
Ah yes, good catch. So there is also a pb here https://github.com/element-hq/element-x-android/blob/develop/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt#L168 ?
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
|
Small cleanup, see the commit messages for more details.